Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoclimbable handrails on harm intent #6652

Merged
merged 20 commits into from
Nov 9, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jul 7, 2024

About the pull request

you do climb when you collide with handrail, rejoice. this makes handrails lot less of an obsticle for both huge xenos and highly rained and agile marines. also there is autoclimbable var that can be set to FALSE on req railing so you can not throw others out of the line

Explain why it's good for the game

handrails can be major pain in ass for both marines and xenos, especily as they are used near ledges so you auto climb from one side to other but have to manualy climb back. they are also sometimes hard to spot and can get you stuck and killed, generly getting stoped by railing that you did not see feels like shit as both sides can shoot or slash it down in seconds. I am gona put this as QOL but if you think it is balance then so be it

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: handrails are autoclimbable when on harm intent, you take some harm when doing so
balance: crusher and ravager destroy handrails when trying to pass them similar to tables
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jul 7, 2024
@cuberound cuberound changed the title autoclimbable handrails autoclimbable handrails on harm intent Jul 8, 2024
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 8, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 16, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jul 19, 2024
@Drulikar Drulikar marked this pull request as draft July 19, 2024 02:37
@cuberound cuberound marked this pull request as ready for review July 28, 2024 19:04
@cuberound cuberound requested a review from Drulikar July 28, 2024 19:04
@Drulikar Drulikar marked this pull request as draft July 29, 2024 09:36
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • if someone else can push you over a railing, the collide should just behave as normal preventing you from moving that direction
  • if you don't want to make railing exceptions via mapping edits, consider instead making a z level check for the Almayer to prevent the auto vaulting of railings on that z level (or maybe only if it's hijack?)

@harryob
Copy link
Member

harryob commented Aug 24, 2024

pr seems to be stale, let us know if you want it re-opening, or just make a fresh pr for it

@harryob harryob closed this Aug 24, 2024
@Drulikar Drulikar reopened this Nov 7, 2024
@cuberound cuberound marked this pull request as ready for review November 7, 2024 21:23
cm13-github added a commit that referenced this pull request Nov 7, 2024
cm13-github added a commit that referenced this pull request Nov 7, 2024
cm13-github added a commit that referenced this pull request Nov 9, 2024
@Drulikar Drulikar added this pull request to the merge queue Nov 9, 2024
Merged via the queue into cmss13-devs:master with commit beaf417 Nov 9, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Quality of Life Make the game harder to play Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants